chromecast/media/cma/pipeline/av_pipeline_impl.h - Issue 857573004: Fix chromium-style errors for WeakPtrFactory member order in Chromecast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/pipeline/av_pipeline_impl.h

Issue 857573004: Fix chromium-style errors for WeakPtrFactory member order in Chromecast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/media/cma/pipeline/av_pipeline_impl.h

diff --git a/chromecast/media/cma/pipeline/av_pipeline_impl.h b/chromecast/media/cma/pipeline/av_pipeline_impl.h

index 4b8856f07f1856fe345b09c61a21c88d8e4cb3d1..20b3fc4feda2e62fa917b28a5c3d7b0e4c32d2aa 100644

--- a/chromecast/media/cma/pipeline/av_pipeline_impl.h

+++ b/chromecast/media/cma/pipeline/av_pipeline_impl.h

@@ -160,8 +160,8 @@ class AvPipelineImpl {

BrowserCdmCast* media_keys_;

int media_keys_callback_id_;

- base::WeakPtrFactory<AvPipelineImpl> weak_factory_;

base::WeakPtr<AvPipelineImpl> weak_this_;

+ base::WeakPtrFactory<AvPipelineImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(AvPipelineImpl);

};

« no previous file with comments | « chromecast/media/cma/pipeline/audio_pipeline_impl.h ('k') | chromecast/media/cma/pipeline/media_pipeline_impl.h » ('j') | no next file with comments »