mac: Fix a dangling delegate bug with MCPopupController.

mac: Fix a dangling delegate bug with MCPopupController.

Due to the odd implementation of MCPopupController, all the clean up happens in
-close rather than -dealloc. In all instances but one, the owner would destroy
MCPopupController by calling -close or -closeWithAnimation. There was one
instance where the owner was calling -release, which was preventing
MCPopupController from properly cleaning up.

BUG=423001
Committed: https://crrev.com/79865bb014b5f6a3a6adcca850ff2b61cfc2bbe0
Cr-Commit-Position: refs/heads/master@{#313316}

[erikchen, 2015-01-20 22:12:32]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2015-01-20 22:12:33]

avi: Please review.

[Avi (use Gerrit), 2015-01-21 05:33:42]

LGTM

Can you DCHECK or something if someone uses the class wrong?

[erikchen, 2015-01-27 00:22:44]

Patchset #2 (id:20001) has been deleted

[erikchen, 2015-01-27 00:23:20]

On 2015/01/21 05:33:42, Avi wrote:
> LGTM
> 
> Can you DCHECK or something if someone uses the class wrong?

I added a DCHECK. PTAL.

[Avi (use Gerrit), 2015-01-27 00:59:53]

https://codereview.chromium.org/857463003/diff/40001/ui/message_center/cocoa/...
File ui/message_center/cocoa/popup_controller.h (right):

https://codereview.chromium.org/857463003/diff/40001/ui/message_center/cocoa/...
ui/message_center/cocoa/popup_controller.h:49: // Has the popup been closed
before being dealloc-ed.
Can you wrap this in #ifndef NDEBUG so that it's debugging only? e.g.
RenderProcessHostImpl :
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

[erikchen, 2015-01-27 04:23:39]

avi: PTAL

https://codereview.chromium.org/857463003/diff/40001/ui/message_center/cocoa/...
File ui/message_center/cocoa/popup_controller.h (right):

https://codereview.chromium.org/857463003/diff/40001/ui/message_center/cocoa/...
ui/message_center/cocoa/popup_controller.h:49: // Has the popup been closed
before being dealloc-ed.
On 2015/01/27 00:59:53, Avi wrote:
> Can you wrap this in #ifndef NDEBUG so that it's debugging only? e.g.
> RenderProcessHostImpl :
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

Good call. Done.

[Avi (use Gerrit), 2015-01-27 05:55:31]

lgtm

[erikchen, 2015-01-27 17:59:51]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857463003/60001

[commit-bot: I haz the power, 2015-01-27 18:50:52]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-01-27 18:51:47]

Patchset 3 (id:??) landed as
https://crrev.com/79865bb014b5f6a3a6adcca850ff2b61cfc2bbe0
Cr-Commit-Position: refs/heads/master@{#313316}