Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: ui/message_center/cocoa/popup_collection.mm

Issue 857463003: mac: Fix a dangling delegate bug with MCPopupController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from avi, round two. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/message_center/cocoa/popup_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/cocoa/popup_collection.mm
diff --git a/ui/message_center/cocoa/popup_collection.mm b/ui/message_center/cocoa/popup_collection.mm
index dfdf1087acee66601f4f6e76faee17be71cffde7..5961e61409b7eb244259e8a598784dd0ecc815f2 100644
--- a/ui/message_center/cocoa/popup_collection.mm
+++ b/ui/message_center/cocoa/popup_collection.mm
@@ -192,8 +192,8 @@ class PopupCollectionObserver : public message_center::MessageCenterObserver {
return YES;
}
- // The popup cannot fit on screen, so it has to be released now.
- [popup release];
+ // The popup cannot fit on screen, so it has to be closed now.
+ [popup close];
return NO;
}
« no previous file with comments | « no previous file | ui/message_center/cocoa/popup_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698