Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 857433003: Update {virtual,override,final} to follow C++11 style chrome/browser/ui. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
msw, Peter Kasting
CC:
dcheng, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, kalyank, sadrul, James Su, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style chrome/browser/ui. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=msw@chromium.org Committed: https://crrev.com/465662ed7e306369e589acf088ff311522a79385 Cr-Commit-Position: refs/heads/master@{#312354}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -252 lines) Patch
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 3 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/keyboard_controller_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 7 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 8 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 1 chunk +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +27 lines, -31 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/user_accounts_delegate_chromeos.h View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.h View 4 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_factory.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:18:58 UTC) #1
dcheng
+pkasting
5 years, 11 months ago (2015-01-20 18:24:42 UTC) #3
Peter Kasting
Rubber-stamp LGTM
5 years, 11 months ago (2015-01-20 21:16:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433003/1
5 years, 11 months ago (2015-01-20 21:53:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/38843) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/34378) android_chromium_gn_compile_rel ...
5 years, 11 months ago (2015-01-20 21:58:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433003/20001
5 years, 11 months ago (2015-01-20 22:06:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/219) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 22:30:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433003/40001
5 years, 11 months ago (2015-01-20 22:34:05 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112610) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96553) Try ...
5 years, 11 months ago (2015-01-21 02:09:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433003/40001
5 years, 11 months ago (2015-01-21 02:13:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112610) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96553)
5 years, 11 months ago (2015-01-21 02:15:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857433003/40001
5 years, 11 months ago (2015-01-21 03:18:56 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 14:19:50 UTC) #23
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:21:21 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/465662ed7e306369e589acf088ff311522a79385
Cr-Commit-Position: refs/heads/master@{#312354}

Powered by Google App Engine
This is Rietveld 408576698