Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5886)

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.h

Issue 857433003: Update {virtual,override,final} to follow C++11 style chrome/browser/ui. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/select_file_dialog_extension.h
diff --git a/chrome/browser/ui/views/select_file_dialog_extension.h b/chrome/browser/ui/views/select_file_dialog_extension.h
index 1e6d191f27802fa948bbcf43de0efee5dbb3b663..8d70adda9e21df32bcc783b53d9954fa2b0d146d 100644
--- a/chrome/browser/ui/views/select_file_dialog_extension.h
+++ b/chrome/browser/ui/views/select_file_dialog_extension.h
@@ -43,12 +43,12 @@ class SelectFileDialogExtension
ui::SelectFilePolicy* policy);
// BaseShellDialog implementation.
- virtual bool IsRunning(gfx::NativeWindow owner_window) const override;
- virtual void ListenerDestroyed() override;
+ bool IsRunning(gfx::NativeWindow owner_window) const override;
+ void ListenerDestroyed() override;
// ExtensionDialog::Observer implementation.
- virtual void ExtensionDialogClosing(ExtensionDialog* dialog) override;
- virtual void ExtensionTerminated(ExtensionDialog* dialog) override;
+ void ExtensionDialogClosing(ExtensionDialog* dialog) override;
+ void ExtensionTerminated(ExtensionDialog* dialog) override;
// Routes callback to appropriate SelectFileDialog::Listener based on the
// owning |web_contents|.
@@ -65,15 +65,14 @@ class SelectFileDialogExtension
protected:
// SelectFileDialog implementation.
- virtual void SelectFileImpl(
- Type type,
- const base::string16& title,
- const base::FilePath& default_path,
- const FileTypeInfo* file_types,
- int file_type_index,
- const base::FilePath::StringType& default_extension,
- gfx::NativeWindow owning_window,
- void* params) override;
+ void SelectFileImpl(Type type,
+ const base::string16& title,
+ const base::FilePath& default_path,
+ const FileTypeInfo* file_types,
+ int file_type_index,
+ const base::FilePath::StringType& default_extension,
+ gfx::NativeWindow owning_window,
+ void* params) override;
private:
friend class SelectFileDialogExtensionBrowserTest;
@@ -82,7 +81,7 @@ class SelectFileDialogExtension
// Object is ref-counted, use Create().
explicit SelectFileDialogExtension(SelectFileDialog::Listener* listener,
ui::SelectFilePolicy* policy);
- virtual ~SelectFileDialogExtension();
+ ~SelectFileDialogExtension() override;
// Invokes the appropriate file selection callback on our listener.
void NotifyListener();
@@ -94,7 +93,7 @@ class SelectFileDialogExtension
static bool PendingExists(RoutingID routing_id);
// Returns true if the dialog has multiple file type choices.
- virtual bool HasMultipleFileTypeChoicesImpl() override;
+ bool HasMultipleFileTypeChoicesImpl() override;
bool has_multiple_file_type_choices_;

Powered by Google App Engine
This is Rietveld 408576698