Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1567)

Unified Diff: pkg/analysis_server/lib/src/socket_server.dart

Issue 857283003: Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with Intel… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/socket_server.dart
diff --git a/pkg/analysis_server/lib/src/socket_server.dart b/pkg/analysis_server/lib/src/socket_server.dart
index f2038ecf283d3725a778c32f582e25a93105cce9..c214263899fa85fa69240d9b6b12926c246b5859 100644
--- a/pkg/analysis_server/lib/src/socket_server.dart
+++ b/pkg/analysis_server/lib/src/socket_server.dart
@@ -62,8 +62,13 @@ class SocketServer {
});
return;
}
- PhysicalResourceProvider resourceProvider =
- PhysicalResourceProvider.INSTANCE;
+ PhysicalResourceProvider resourceProvider;
+ if (analysisServerOptions.fileReadMode == 'normalize-eol') {
+ resourceProvider = PhysicalResourceProvider.INSTANCE_NORMALIZE_EOL;
+ } else {
Paul Berry 2015/01/20 19:10:53 I would feel a lot more comfortable if we changed
jwren 2015/01/20 21:38:14 Done.
+ resourceProvider = PhysicalResourceProvider.INSTANCE;
+ }
+
analysisServer = new AnalysisServer(
serverChannel,
resourceProvider,

Powered by Google App Engine
This is Rietveld 408576698