Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with Intel…

pkg/analysis_server/lib/src/socket_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library socket.server;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/channel/channel.dart';
 import 'package:analysis_server/src/plugin/server_plugin.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 44 matching lines @@
     if (analysisServer != null) {
       RequestError error = new RequestError(
           RequestErrorCode.SERVER_ALREADY_STARTED,
           "Server already started");
       serverChannel.sendResponse(new Response('', error: error));
       serverChannel.listen((Request request) {
         serverChannel.sendResponse(new Response(request.id, error: error));
       });
       return;
     }
-    PhysicalResourceProvider resourceProvider =
-        PhysicalResourceProvider.INSTANCE;
+    PhysicalResourceProvider resourceProvider;
+    if (analysisServerOptions.fileReadMode == 'normalize-eol') {
+      resourceProvider = PhysicalResourceProvider.INSTANCE_NORMALIZE_EOL;
+    } else {

[Paul Berry, 2015/01/20 19:10:53]

I would feel a lot more comfortable if we changed this to:

...
} else  if (analysisServerOptions.fileReadMode == 'as-is') {
  resourceProvider = PhysicalResourceProvider.INSTANCE;
} else {
  ... throw an exception ...
}

just so that we don't have an implicit dependency on code in some other file to
validate the string for us.

[jwren, 2015/01/20 21:38:14]

Done.

+      resourceProvider = PhysicalResourceProvider.INSTANCE;
+    }
+
     analysisServer = new AnalysisServer(
         serverChannel,
         resourceProvider,
         new PubPackageMapProvider(resourceProvider, defaultSdk),
         _createIndex(),
         analysisServerOptions,
         defaultSdk,
         instrumentationService,
         rethrowExceptions: false);
     _initializeHandlers(analysisServer);
   }
 
   /**
    * Initialize the handlers to be used by the given [server].
    */
   void _initializeHandlers(AnalysisServer server) {
     server.handlers = serverPlugin.createDomains(server);
   }
 }