Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 857283002: Makes a couple of tests reset state appropriately (Closed)

Created:
5 years, 11 months ago by sky
Modified:
5 years, 11 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, glider+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, jdduke+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes a couple of tests reset state appropriately A couple of tests were setting the ScreenTypeDelegate or Screen during Setup but never resetting during Teardown. This lead to future tests failing. BUG=448189 TEST=covered by tests R=sadrul@chromium.org Committed: https://crrev.com/4a193b718a4a09e74ed11f6642e32b55e9e0e955 Cr-Commit-Position: refs/heads/master@{#312268}

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/test/base/view_event_test_platform_part_ash.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/screen.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sky
5 years, 11 months ago (2015-01-20 17:48:56 UTC) #2
sadrul
LGTM Would having some ScopedScreenInstall object that sets/unsets things correctly be less error-prone?
5 years, 11 months ago (2015-01-20 18:48:14 UTC) #3
sky
Definitely. I started going down that route but it started getting rather large so I ...
5 years, 11 months ago (2015-01-20 18:56:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857283002/20001
5 years, 11 months ago (2015-01-20 18:58:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/26838)
5 years, 11 months ago (2015-01-20 19:56:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857283002/20001
5 years, 11 months ago (2015-01-20 20:06:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-20 20:55:06 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 20:57:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a193b718a4a09e74ed11f6642e32b55e9e0e955
Cr-Commit-Position: refs/heads/master@{#312268}

Powered by Google App Engine
This is Rietveld 408576698