Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: ui/gfx/screen.h

Issue 857283002: Makes a couple of tests reset state appropriately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweak Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/screen.h
diff --git a/ui/gfx/screen.h b/ui/gfx/screen.h
index 44b58c3b9935050b314ad63c070c3fbe6b89ff13..65d78fe4a4f4f9b5683ec27bfab26dfa6d9ae897 100644
--- a/ui/gfx/screen.h
+++ b/ui/gfx/screen.h
@@ -37,6 +37,8 @@ class GFX_EXPORT Screen {
// Sets the global screen for a particular screen type. Only the _NATIVE
// ScreenType must be provided.
+ // NOTE: this does not take ownership of |screen|. Tests must be sure to
+ // reset any state they install.
static void SetScreenInstance(ScreenType type, Screen* instance);
// Returns the global screen for a particular type. Types other than _NATIVE
@@ -45,6 +47,8 @@ class GFX_EXPORT Screen {
// Sets the global ScreenTypeDelegate. May be left unset if the platform
// uses only the _NATIVE ScreenType.
+ // NOTE: this does not take ownership of |delegate|. Tests must be sure to
+ // reset any state they install.
static void SetScreenTypeDelegate(ScreenTypeDelegate* delegate);
Screen();
« no previous file with comments | « tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698