|
Get rid of Reset and ResetStyleResolverAndFontSelector.
Now that we store RuleSets on StyleSheetContents, recreating
the StyleResolver is much cheaper. By getting rid of the Reset
codepaths we can simplify a lot of code and get rid of a lot
of duplication.
Also, this is generally less error prone since we don't have to worry
about some random subset of StyleResolver's member variables not
getting updated properly.
If we find recreating the StyleResolver on profiles, we should
look into moving the more expensive bits to better locations
(e.g. maybe fontSelector shouldn't live on StyleResolver).
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+53 lines, -202 lines) |
Patch |
|
M |
LayoutTests/fast/css/add-remove-stylesheets-minimal-recalc-style.html
|
View
|
|
1 chunk |
+2 lines, -1 line |
1 comment
|
Download
|
|
M |
LayoutTests/fast/css/add-remove-stylesheets-minimal-recalc-style-expected.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/ScopedStyleResolver.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/ScopedStyleResolver.cpp
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/StyleResolver.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/StyleResolver.cpp
|
View
|
|
3 chunks |
+0 lines, -44 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/DocumentStyleSheetCollection.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/DocumentStyleSheetCollection.cpp
|
View
|
|
2 chunks |
+12 lines, -43 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/ShadowTreeStyleSheetCollection.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/ShadowTreeStyleSheetCollection.cpp
|
View
|
|
1 chunk |
+0 lines, -32 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/StyleEngine.cpp
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/StyleSheetCollection.h
|
View
|
|
4 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/StyleSheetCollection.cpp
|
View
|
|
5 chunks |
+29 lines, -59 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|