Issue 856773003: Fix missing call to destroy library in embedder test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 856773003: Fix missing call to destroy library in embedder test. (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix missing call to destroy library in embedder test. This was somehow lost along the way to creating embedder tests. Presumably this silently leaks in origin/master, but triggers an assert under XFA. Fixing this on master is a pre-requisite for merging all the embedder test code onto XFA. TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aa7b4ede03764a5701a477b601720a32c88d8e42

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	testing/embedder_test.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

5 years, 11 months ago (2015-01-16 17:43:52 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aa7b4ede03764a5701a477b601720a32c88d8e42 (presubmit successful).

Expand Messages | Collapse Messages