Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(395)

Issue 856773003: Fix missing call to destroy library in embedder test. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix missing call to destroy library in embedder test. This was somehow lost along the way to creating embedder tests. Presumably this silently leaks in origin/master, but triggers an assert under XFA. Fixing this on master is a pre-requisite for merging all the embedder test code onto XFA. TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/aa7b4ede03764a5701a477b601720a32c88d8e42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/embedder_test.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Tom Sepez
5 years, 8 months ago (2015-01-16 17:43:52 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aa7b4ede03764a5701a477b601720a32c88d8e42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698