chrome/browser/about_flags.cc - Issue 856643002: Viewing cached webpages while offline is not available on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 856643002: Viewing cached webpages while offline is not available on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | chrome/renderer/resources/neterror.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 270e77c53747148e44d852628a5ebc2467d9c686..6d702849a02d9bf8fe8dd26bee414e5bd9f5a51e 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -2154,6 +2154,14 @@ const Experiment kExperiments[] = {

kOsDesktop,

SINGLE_VALUE_TYPE(switches::kEnableDelayAgnosticAec)

+ {

+ "enable-new-offline-error-page",

+ IDS_FLAGS_ENABLE_NEW_OFFLINE_ERROR_PAGE,

+ IDS_FLAGS_ENABLE_NEW_OFFLINE_ERROR_PAGE_DESCRIPTION,

+ kOsCrOS,

+ ENABLE_DISABLE_VALUE_TYPE(switches::kEnableNewOfflineErrorPage,

+ switches::kDisableNewOfflineErrorPage)

+ },

oshima 2015/01/23 21:49:03 I still think we don't need about flags. We want t

afakhry 2015/01/24 00:53:16 Done.

// NOTE: Adding new command-line switches requires adding corresponding

// entries to enum "LoginCustomFlags" in histograms.xml. See note in