Viewing cached webpages while offline is not available on Chrome OS

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 2136 matching lines @@
     SINGLE_VALUE_TYPE(switches::kEnablePotentiallyAnnoyingSecurityFeatures)
   },
 #endif
   {
     "enable-delay-agnostic-aec",
     IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_NAME,
     IDS_FLAGS_ENABLE_DELAY_AGNOSTIC_AEC_DESCRIPTION,
     kOsDesktop,
     SINGLE_VALUE_TYPE(switches::kEnableDelayAgnosticAec)
   },
+  {
+    "enable-new-offline-error-page",
+    IDS_FLAGS_ENABLE_NEW_OFFLINE_ERROR_PAGE,
+    IDS_FLAGS_ENABLE_NEW_OFFLINE_ERROR_PAGE_DESCRIPTION,
+    kOsCrOS,
+    ENABLE_DISABLE_VALUE_TYPE(switches::kEnableNewOfflineErrorPage,
+                              switches::kDisableNewOfflineErrorPage)
+  },

[oshima, 2015/01/23 21:49:03]

I still think we don't need about flags. We want to consolidate it sooner and
this isn't something that we want a user to play with.

I'm ok to have "disable" command line flag in case we need it for
troubleshooting though.

[afakhry, 2015/01/24 00:53:16]

Done.

 
   // NOTE: Adding new command-line switches requires adding corresponding
   // entries to enum "LoginCustomFlags" in histograms.xml. See note in
   // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
 };
 
 const Experiment* experiments = kExperiments;
 size_t num_experiments = arraysize(kExperiments);
 
 // Stores and encapsulates the little state that about:flags has.
@@ skipping 559 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags