Issue 856623004: Merge to XFA: PDFium embeddertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 856623004: Merge to XFA: PDFium embeddertests. (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: PDFium embeddertests. This consists of two origin/master CLs: Review URL: https://codereview.chromium.org/857483005 Review URL: https://codereview.chromium.org/827733006 It also fixes a couple of segv's in XFA when the library is initialized and destroyed multiple times in the same process. R=jam@chromium.org TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/96d1334cb605aab143d3135da4d4550920735e91

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+480 lines, -12 lines)			Patch
A	fpdfsdk/src/fpdfview_embeddertest.cpp	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	testing/embedder_test.h	View		1 chunk	+82 lines, -0 lines	0 comments	Download
A	testing/embedder_test.cpp	View	1	1 chunk	+309 lines, -0 lines	0 comments	Download
A	testing/resources/about_blank.pdf	View		Binary file		0 comments	Download
M	xfa/src/fwl/src/core/fwl_appimp.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	xfa/src/fwl/src/core/fwl_noteimp.cpp	View	1	2 chunks	+15 lines, -4 lines	0 comments	Download
M	xfa/src/fwl/src/core/include/fwl_noteimp.h	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	xfa/src/fxjse/src/runtime.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Tom Sepez

John, you're going to have to take a look at this again, since I had ...

5 years, 11 months ago (2015-01-16 22:19:58 UTC) #2

Tom Sepez

5 years, 11 months ago (2015-01-16 22:59:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
96d1334cb605aab143d3135da4d4550920735e91 (presubmit successful).