Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 857483005: Follow-on to pdfium_embeddertests. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Follow-on to pdfium_embeddertests. This includes: - Fix TestLoader lifetime. - Rename test file to match the equivalent .cpp under test - Re-organize a few tests to avoid duplicate loading - add tests for a few additional functions. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/74b91b279d0dee175c2e461ffa4fcc7fe5002a6e

Patch Set 1 #

Patch Set 2 : Remove unneeded change. #

Patch Set 3 : Rename file to match the tested .cpp. #

Total comments: 2

Patch Set 4 : Fix copyright. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -23 lines) Patch
A fpdfsdk/src/fpdfview_embeddertest.cpp View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M testing/basic_embeddertest.cpp View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M testing/embedder_test.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
John, please review.
5 years, 11 months ago (2015-01-16 01:10:59 UTC) #2
jam
lgtm https://codereview.chromium.org/857483005/diff/40001/fpdfsdk/src/fpdfview_embeddertest.cpp File fpdfsdk/src/fpdfview_embeddertest.cpp (right): https://codereview.chromium.org/857483005/diff/40001/fpdfsdk/src/fpdfview_embeddertest.cpp#newcode1 fpdfsdk/src/fpdfview_embeddertest.cpp:1: // Copyright (c) 2015 PDFium Authors. All rights ...
5 years, 11 months ago (2015-01-16 16:18:37 UTC) #3
Tom Sepez
https://codereview.chromium.org/857483005/diff/40001/fpdfsdk/src/fpdfview_embeddertest.cpp File fpdfsdk/src/fpdfview_embeddertest.cpp (right): https://codereview.chromium.org/857483005/diff/40001/fpdfsdk/src/fpdfview_embeddertest.cpp#newcode1 fpdfsdk/src/fpdfview_embeddertest.cpp:1: // Copyright (c) 2015 PDFium Authors. All rights reserved. ...
5 years, 11 months ago (2015-01-16 16:54:48 UTC) #4
Tom Sepez
5 years, 11 months ago (2015-01-16 16:55:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
74b91b279d0dee175c2e461ffa4fcc7fe5002a6e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698