Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 856563004: Update {virtual,override,final} to follow C++11 style in chromeos. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
oshima, Daniel Erat, zel
CC:
chromium-reviews, dkrahn+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chromeos. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=zelidrag@chromium.org Committed: https://crrev.com/ae98daac90e8a97f807911858856fcb402c36860 Cr-Commit-Position: refs/heads/master@{#312426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -305 lines) Patch
M chromeos/attestation/mock_attestation_flow.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/audio/audio_devices_pref_handler_impl.h View 1 chunk +9 lines, -10 lines 0 comments Download
M chromeos/audio/cras_audio_handler.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 2 chunks +11 lines, -22 lines 0 comments Download
M chromeos/cert_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/cryptohome/async_method_caller.cc View 15 chunks +32 lines, -35 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 6 chunks +25 lines, -25 lines 0 comments Download
M chromeos/cryptohome/homedir_methods_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/cryptohome/system_salt_getter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 7 chunks +19 lines, -22 lines 0 comments Download
M chromeos/disks/disk_mount_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/geolocation/simple_geolocation_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 3 chunks +16 lines, -16 lines 0 comments Download
M chromeos/login/auth/extended_authenticator_impl.h View 1 chunk +21 lines, -24 lines 0 comments Download
M chromeos/login/auth/fake_extended_authenticator.h View 1 chunk +22 lines, -24 lines 0 comments Download
M chromeos/login/auth/login_performer.h View 4 chunks +7 lines, -7 lines 0 comments Download
M chromeos/login/auth/mock_authenticator.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chromeos/login/auth/mock_url_fetchers.h View 6 chunks +12 lines, -12 lines 0 comments Download
M chromeos/login/auth/online_attempt.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/login/auth/online_attempt_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/test_attempt_state.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chromeos/login/login_state_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/process_proxy/process_proxy_unittest.cc View 8 chunks +19 lines, -18 lines 0 comments Download
M chromeos/settings/timezone_settings.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chromeos/system/fake_statistics_provider.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chromeos/timezone/timezone_request.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:24:46 UTC) #1
dcheng
+oshima
5 years, 11 months ago (2015-01-20 18:25:16 UTC) #3
dcheng
+derat, any chance you can take a look at this? This is the last large ...
5 years, 11 months ago (2015-01-21 19:05:10 UTC) #5
Daniel Erat
sure! lgtm
5 years, 11 months ago (2015-01-21 19:30:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856563004/1
5 years, 11 months ago (2015-01-21 19:44:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 20:31:16 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 20:32:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae98daac90e8a97f807911858856fcb402c36860
Cr-Commit-Position: refs/heads/master@{#312426}

Powered by Google App Engine
This is Rietveld 408576698