Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11304)

Unified Diff: chromeos/login/auth/online_attempt.h

Issue 856563004: Update {virtual,override,final} to follow C++11 style in chromeos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/login/auth/mock_url_fetchers.h ('k') | chromeos/login/auth/online_attempt_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/login/auth/online_attempt.h
diff --git a/chromeos/login/auth/online_attempt.h b/chromeos/login/auth/online_attempt.h
index e03684b8c5e2ab4f14809eccc2e5ffe631c93c03..032d2f5f3eebd2bd2064c3b16655bc97c46f5f68 100644
--- a/chromeos/login/auth/online_attempt.h
+++ b/chromeos/login/auth/online_attempt.h
@@ -31,7 +31,7 @@ class CHROMEOS_EXPORT OnlineAttempt : public GaiaAuthConsumer {
public:
OnlineAttempt(AuthAttemptState* current_attempt,
AuthAttemptStateResolver* callback);
- virtual ~OnlineAttempt();
+ ~OnlineAttempt() override;
// Initiate the online login attempt either through client or auth login.
// Status will be recorded in |current_attempt|, and resolver_->Resolve() will
@@ -40,9 +40,8 @@ class CHROMEOS_EXPORT OnlineAttempt : public GaiaAuthConsumer {
void Initiate(net::URLRequestContextGetter* request_context);
// GaiaAuthConsumer overrides. Callbacks from GaiaAuthFetcher
- virtual void OnClientLoginFailure(
- const GoogleServiceAuthError& error) override;
- virtual void OnClientLoginSuccess(
+ void OnClientLoginFailure(const GoogleServiceAuthError& error) override;
+ void OnClientLoginSuccess(
const GaiaAuthConsumer::ClientLoginResult& credentials) override;
private:
« no previous file with comments | « chromeos/login/auth/mock_url_fetchers.h ('k') | chromeos/login/auth/online_attempt_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698