chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc - Issue 856543004: Replace incident type handlers with implementations of Incident.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc

Issue 856543004: Replace incident type handlers with implementations of Incident. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: robertshield comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc b/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc

index b8dbecc9e5c8885fe67e19fc3c1a52f37846ba0a..6fe04e164f07cf52903574ea53d88821abd15a2c 100644

--- a/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc

@@ -10,6 +10,7 @@

#include "base/location.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/metrics/variations/variations_service.h"

+#include "chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "content/public/browser/browser_thread.h"

@@ -27,13 +28,13 @@ void VerifyVariationsSeedSignatureOnUIThread(

std::string invalid_signature =

variations_service->GetInvalidVariationsSeedSignature();

if (!invalid_signature.empty()) {

- scoped_ptr<ClientIncidentReport_IncidentData> incident_data(

- new ClientIncidentReport_IncidentData());

- ClientIncidentReport_IncidentData_VariationsSeedSignatureIncident*

- variations_seed_signature =

- incident_data->mutable_variations_seed_signature();

+ scoped_ptr<

+ ClientIncidentReport_IncidentData_VariationsSeedSignatureIncident>

+ variations_seed_signature(

+ new ClientIncidentReport_IncidentData_VariationsSeedSignatureIncident());

variations_seed_signature->set_variations_seed_signature(invalid_signature);

- callback.Run(incident_data.Pass());

+ callback.Run(make_scoped_ptr(

+ new VariationsSeedSignatureIncident(variations_seed_signature.Pass())));

}