Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 856503002: Massive renaming of PropertyType values and other implied stuff. (Closed)

Created:
5 years, 11 months ago by Igor Sheludko
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Massive renaming of PropertyType values and other implied stuff. PropertyKind: DATA -> kData ACCESSOR -> kAccessor PropertyType: FIELD -> DATA CONSTANT -> DATA_CONSTANT ACCESSOR_FIELD -> ACCESSOR CALLBACKS -> ACCESSOR_CONSTANT PropertyLocation: IN_OBJECT -> kField IN_DESCRIPTOR -> kDescriptor StoreMode: FORCE_IN_OBJECT -> FORCE_FIELD FieldDescriptor -> DataDescriptor ConstantDescriptor -> DataConstantDescriptor CallbacksDescriptor -> AccessorConstantDescriptor Committed: https://crrev.com/33994b4a22834efb26620ffa3053a5d15d48a6bd Cr-Commit-Position: refs/heads/master@{#26146}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Addressing comments #

Patch Set 4 : Spurious file addition fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -428 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 26 chunks +106 lines, -104 lines 0 comments Download
M src/elements.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 2 11 chunks +16 lines, -16 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 2 5 chunks +6 lines, -5 lines 0 comments Download
M src/json-stringifier.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/layout-descriptor-inl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 2 7 chunks +8 lines, -8 lines 0 comments Download
M src/lookup-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mirror-debugger.js View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 70 chunks +160 lines, -153 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M src/objects-printer.cc View 1 2 2 chunks +12 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/property.h View 1 2 7 chunks +28 lines, -35 lines 0 comments Download
M src/property.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M src/property-details.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M src/runtime/runtime.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/string-stream.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/transitions.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 2 8 chunks +15 lines, -14 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/mirror-object.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-merge-descriptors.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Igor Sheludko
PTAL. https://codereview.chromium.org/856503002/diff/20001/src/mirror-debugger.js File src/mirror-debugger.js (right): https://codereview.chromium.org/856503002/diff/20001/src/mirror-debugger.js#newcode184 src/mirror-debugger.js:184: PropertyType.DataConstant = 2; This should have been fixed ...
5 years, 11 months ago (2015-01-15 14:22:44 UTC) #2
Igor Sheludko
Addressed comments
5 years, 11 months ago (2015-01-19 13:39:23 UTC) #5
Toon Verwaest
lgtm, but you probably didn't want to add test/cctest/test-migrations.cc1; so remove that again please.
5 years, 11 months ago (2015-01-19 16:42:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856503002/100001
5 years, 11 months ago (2015-01-19 17:21:56 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 11 months ago (2015-01-19 17:49:22 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 17:49:33 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/33994b4a22834efb26620ffa3053a5d15d48a6bd
Cr-Commit-Position: refs/heads/master@{#26146}

Powered by Google App Engine
This is Rietveld 408576698