Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 856473002: Inherit Presentation role only when elements without a explicit role defined. (Closed)

Created:
5 years, 11 months ago by je_julie(Not used)
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Inherit Presentation role only when elements without a explicit role defined. The presentation role can be inherited to owned children only when it doesn't a implicit role defined. AXRenderObject::inheritsPresentationalRole() is used to check that the presentation role can be inherited or not. This patch added checking if element has a explicit role defined to AXRenderObject::inheritsPresentationalRole(). The related spec, http://www.w3.org/TR/wai-aria/roles#presentation. BUG=447994 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188479

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
A LayoutTests/accessibility/listitem-presentation-inherited.html View 1 chunk +51 lines, -0 lines 1 comment Download
A LayoutTests/accessibility/listitem-presentation-inherited-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
je_julie(Not used)
Hi Dominic, This patch makes presentation role can be inherited only when element doesn't have ...
5 years, 11 months ago (2015-01-15 10:35:55 UTC) #2
dmazzoni
lgtm Sounds great, this change looks good and it'd be great to follow it up ...
5 years, 11 months ago (2015-01-15 16:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856473002/1
5 years, 11 months ago (2015-01-15 16:05:44 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 17:15:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188479

Powered by Google App Engine
This is Rietveld 408576698