Source/modules/accessibility/AXRenderObject.cpp - Issue 856473002: Inherit Presentation role only when elements without a explicit role defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 856473002: Inherit Presentation role only when elements without a explicit role defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/accessibility/listitem-presentation-inherited.html ('K') | « LayoutTests/accessibility/listitem-presentation-inherited-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXRenderObject.cpp

diff --git a/Source/modules/accessibility/AXRenderObject.cpp b/Source/modules/accessibility/AXRenderObject.cpp

index 36cac22763c6e9ebd1dcfefb04cd21c80a494b5c..1073f3a48ee57698f69f2e011e07702122fd4964 100644

--- a/Source/modules/accessibility/AXRenderObject.cpp

+++ b/Source/modules/accessibility/AXRenderObject.cpp

@@ -2366,8 +2366,11 @@ bool AXRenderObject::inheritsPresentationalRole() const

return false;

QualifiedName tagName = toElement(elementNode)->tagQName();

- if (tagName == ulTag || tagName == olTag || tagName == dlTag)

- return (parent->roleValue() == NoneRole || parent->roleValue() == PresentationalRole);

+ if (tagName != ulTag && tagName != olTag && tagName != dlTag)

+ return false;

+ if (parent->roleValue() == NoneRole || parent->roleValue() == PresentationalRole)

+ return ariaRoleAttribute() == UnknownRole;

return false;

}