Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2830)

Unified Diff: content/renderer/render_view_impl.cc

Issue 85643002: Transfer date/time value to chooser as double (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doubledate2
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index b21d9e047b9a4e914326cd43acb012f2db1e9439..1f36176e7390ee3eeed91aced512a7b21d1b0795 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -6378,11 +6378,18 @@ void RenderViewImpl::LaunchAndroidContentIntent(const GURL& intent,
bool RenderViewImpl::openDateTimeChooser(
const blink::WebDateTimeChooserParams& params,
blink::WebDateTimeChooserCompletion* completion) {
+ if (date_time_picker_client_)
Miguel Garcia 2013/11/26 16:07:08 Please add a comment stating when can this happen,
keishi 2013/11/27 06:58:38 Done. JavaScript runs while the dialog is open, an
+ return false;
date_time_picker_client_.reset(
new RendererDateTimePicker(this, params, completion));
return date_time_picker_client_->Open();
}
+void RenderViewImpl::DidDismissDateTimeDialog() {
Miguel Garcia 2013/11/26 16:07:08 This is such a simple implementation that perhaps
keishi 2013/11/27 06:58:38 Done.
+ DCHECK(date_time_picker_client_);
+ date_time_picker_client_.reset(NULL);
+}
+
WebMediaPlayer* RenderViewImpl::CreateAndroidWebMediaPlayer(
WebFrame* frame,
const blink::WebURL& url,

Powered by Google App Engine
This is Rietveld 408576698