Transfer date/time value to chooser as double

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 6360 matching lines @@
   // Remove the content highlighting if any.
   scheduleComposite();
 
   if (!intent.is_empty())
     Send(new ViewHostMsg_StartContentIntent(routing_id_, intent));
 }
 
 bool RenderViewImpl::openDateTimeChooser(
     const blink::WebDateTimeChooserParams& params,
     blink::WebDateTimeChooserCompletion* completion) {
+  if (date_time_picker_client_)

[Miguel Garcia, 2013/11/26 16:07:08]

Please add a comment stating when can this happen, I can't see how you can have
more than one dialog open since they are full screen. Specially within the same
renderer.

[keishi, 2013/11/27 06:58:38]

Done.
JavaScript runs while the dialog is open, and JavaScript can open date/time
dialogs.

+    return false;
   date_time_picker_client_.reset(
       new RendererDateTimePicker(this, params, completion));
   return date_time_picker_client_->Open();
 }
 
+void RenderViewImpl::DidDismissDateTimeDialog() {

[Miguel Garcia, 2013/11/26 16:07:08]

This is such a simple implementation that perhaps you can inline it in the .h
file. See my comment about the signature as well.

[keishi, 2013/11/27 06:58:38]

Done.

+  DCHECK(date_time_picker_client_);
+  date_time_picker_client_.reset(NULL);
+}
+
 WebMediaPlayer* RenderViewImpl::CreateAndroidWebMediaPlayer(
       WebFrame* frame,
       const blink::WebURL& url,
       WebMediaPlayerClient* client) {
   GpuChannelHost* gpu_channel_host =
       RenderThreadImpl::current()->EstablishGpuChannelSync(
           CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
   if (!gpu_channel_host) {
     LOG(ERROR) << "Failed to establish GPU channel for media player";
     return NULL;
@@ skipping 283 matching lines @@
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content