Transfer date/time value to chooser as double

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index df630d3e0c5b514d1f7ae2031fc753accd39a4cb..fd7733c7f70184c047c671b02e9f99244a103381 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -393,15 +393,8 @@ IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeDialogValue_Params)
-  IPC_STRUCT_MEMBER(int, dialog_type)
-  IPC_STRUCT_MEMBER(int, year)
-  IPC_STRUCT_MEMBER(int, month)
-  IPC_STRUCT_MEMBER(int, day)
-  IPC_STRUCT_MEMBER(int, hour)
-  IPC_STRUCT_MEMBER(int, minute)
-  IPC_STRUCT_MEMBER(int, second)
-  IPC_STRUCT_MEMBER(int, milli)
-  IPC_STRUCT_MEMBER(int, week)
+  IPC_STRUCT_MEMBER(ui::TextInputType, dialog_type)
+  IPC_STRUCT_MEMBER(double, dialog_value)
   IPC_STRUCT_MEMBER(double, minimum)
   IPC_STRUCT_MEMBER(double, maximum)
   IPC_STRUCT_MEMBER(double, step)
@@ -973,7 +966,7 @@ IPC_MESSAGE_ROUTED1(ViewMsg_SetBrowserRenderingStats,
 
 // Replaces a date time input field.
 IPC_MESSAGE_ROUTED1(ViewMsg_ReplaceDateTime,
-                    ViewHostMsg_DateTimeDialogValue_Params /* value */)
+                    double /* dialog_value */)

[Miguel Garcia, 2013/11/26 16:07:08]

so if you are passing milliseconds since epoch why are you using a double
(floating point) instead of simply an int64? I guess the same applies for min
and max.

[keishi, 2013/11/27 06:58:37]

The HTML spec defines min/max for the date/time values. dialog_value will always
be between -62135596800000.0 and 8640000000000000.0 so we can use double without
loss in precision. We can also express an empty value as NaN.

[Miguel Garcia, 2013/11/27 11:17:24]

Ok, would be nice to know what happens if we actually pass a value that is not
within those boundaries, can we get an overflow? or is blink taking care of
that?

On 2013/11/27 06:58:37, keishi1 wrote:

[keishi, 2013/11/29 03:30:14]

Blink only send valid values to chromium so the value should always be in this
range.

 
 // Copies the image at location x, y to the clipboard (if there indeed is an
 // image at that location).