Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/browser/android/date_time_chooser_android.cc

Issue 85643002: Transfer date/time value to chooser as double (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@doubledate2
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/date_time_chooser_android.cc
diff --git a/content/browser/android/date_time_chooser_android.cc b/content/browser/android/date_time_chooser_android.cc
index be87a932e1c922814c0d18fd2eeb949eacb09912..d9f96acadeedc37c0e6a436aae3dbaf787dc49c8 100644
--- a/content/browser/android/date_time_chooser_android.cc
+++ b/content/browser/android/date_time_chooser_android.cc
@@ -40,26 +40,9 @@ void DateTimeChooserAndroid::InitializeDateInputTypes(
void DateTimeChooserAndroid::ReplaceDateTime(JNIEnv* env,
jobject,
- int dialog_type,
- int year,
- int month,
- int day,
- int hour,
- int minute,
- int second,
- int milli,
- int week) {
- ViewHostMsg_DateTimeDialogValue_Params value;
- value.year = year;
- value.month = month;
- value.day = day;
- value.hour = hour;
- value.minute = minute;
- value.second = second;
- value.milli = milli;
- value.week = week;
- value.dialog_type = dialog_type;
- host_->Send(new ViewMsg_ReplaceDateTime(host_->GetRoutingID(), value));
+ jdouble value) {
+ host_->Send(new ViewMsg_ReplaceDateTime(host_->GetRoutingID(),
Miguel Garcia 2013/11/26 16:07:08 I think this fits in one line.
keishi 2013/11/27 06:58:37 Done.
+ value));
}
void DateTimeChooserAndroid::CancelDialog(JNIEnv* env, jobject) {
@@ -68,15 +51,8 @@ void DateTimeChooserAndroid::CancelDialog(JNIEnv* env, jobject) {
void DateTimeChooserAndroid::ShowDialog(ContentViewCore* content,
RenderViewHost* host,
- int type,
- int year,
- int month,
- int day,
- int hour,
- int minute,
- int second,
- int milli,
- int week,
+ int dialog_type,
+ double dialog_value,
double min,
double max,
double step) {
@@ -87,15 +63,8 @@ void DateTimeChooserAndroid::ShowDialog(ContentViewCore* content,
env,
content->GetJavaObject().obj(),
reinterpret_cast<intptr_t>(this),
- type,
- year,
- month,
- day,
- hour,
- minute,
- second,
- milli,
- week,
+ dialog_type,
+ dialog_value,
min,
max,
step));

Powered by Google App Engine
This is Rietveld 408576698