Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 856333002: KeyedStoreIC: support non-generic handling of Symbol keys (Closed)

Created:
5 years, 11 months ago by Jakob Kummerow
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

KeyedStoreIC: support non-generic handling of Symbol keys BUG=chromium:450475 LOG=n Committed: https://crrev.com/89dff787e3c80d793f15a2ff9a5c65b3b2398c89 Cr-Commit-Position: refs/heads/master@{#26188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ic/ic.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
5 years, 11 months ago (2015-01-21 10:18:14 UTC) #2
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-21 10:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856333002/1
5 years, 11 months ago (2015-01-21 10:24:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/826)
5 years, 11 months ago (2015-01-21 11:15:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/856333002/1
5 years, 11 months ago (2015-01-21 13:08:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 13:39:19 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:39:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89dff787e3c80d793f15a2ff9a5c65b3b2398c89
Cr-Commit-Position: refs/heads/master@{#26188}

Powered by Google App Engine
This is Rietveld 408576698