src/ic/ic.cc - Issue 856333002: KeyedStoreIC: support non-generic handling of Symbol keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 856333002: KeyedStoreIC: support non-generic handling of Symbol keys (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 88520029132b9daedba28ae1e5650b3994a1f078..8cd06868c0c3fdd215b87d76ec184bad3307c209 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -2035,10 +2035,10 @@ MaybeHandle<Object> KeyedStoreIC::Store(Handle<Object> object,

Handle<Object> store_handle;

Handle<Code> stub = megamorphic_stub();

- if (key->IsInternalizedString()) {

+ if (key->IsInternalizedString() || key->IsSymbol()) {

ASSIGN_RETURN_ON_EXCEPTION(

isolate(), store_handle,

- StoreIC::Store(object, Handle<String>::cast(key), value,

+ StoreIC::Store(object, Handle<Name>::cast(key), value,

JSReceiver::MAY_BE_STORE_FROM_KEYED),

Object);

if (!is_target_set()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »