Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 856313002: X87: Fix issue with __proto__ when using ES6 object literals. (Closed)

Created:
5 years, 11 months ago by chunyang.dai
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix issue with __proto__ when using ES6 object literals. port bc3b2960e3b7abc16440717f289a430aef904cb1 (r26172). original commit message: Fix issue with __proto__ when using ES6 object literals It should be possible to create a concise method with the name __proto__ without setting the [[Prototype]]. Similarly, property name shorthands with the name __proto__ should define an own property. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/3175d302495ede827e2912656c791acf1440e669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
WL PTAL. thanks
5 years, 11 months ago (2015-01-21 07:53:14 UTC) #2
Weiliang
lgtm
5 years, 11 months ago (2015-01-21 08:11:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3175d302495ede827e2912656c791acf1440e669 Cr-Commit-Position: refs/heads/master@{#26179}
5 years, 11 months ago (2015-01-21 08:31:33 UTC) #4
chunyang.dai
Committed patchset #1 (id:1) manually as 3175d302495ede827e2912656c791acf1440e669 (presubmit successful).
5 years, 11 months ago (2015-01-21 08:31:39 UTC) #5
arv (Not doing code reviews)
5 years, 11 months ago (2015-01-21 15:07:14 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698