Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 856313002: X87: Fix issue with __proto__ when using ES6 object literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2438 matching lines...) Expand 10 before | Expand all | Expand 10 after
2449 } else { 2449 } else {
2450 __ push(Operand(esp, 0)); // prototype 2450 __ push(Operand(esp, 0)); // prototype
2451 } 2451 }
2452 EmitPropertyKey(property); 2452 EmitPropertyKey(property);
2453 VisitForStackValue(value); 2453 VisitForStackValue(value);
2454 EmitSetHomeObjectIfNeeded(value, 2); 2454 EmitSetHomeObjectIfNeeded(value, 2);
2455 2455
2456 switch (property->kind()) { 2456 switch (property->kind()) {
2457 case ObjectLiteral::Property::CONSTANT: 2457 case ObjectLiteral::Property::CONSTANT:
2458 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2458 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2459 case ObjectLiteral::Property::PROTOTYPE:
2460 UNREACHABLE();
2459 case ObjectLiteral::Property::COMPUTED: 2461 case ObjectLiteral::Property::COMPUTED:
2460 case ObjectLiteral::Property::PROTOTYPE:
2461 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2462 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2462 break; 2463 break;
2463 2464
2464 case ObjectLiteral::Property::GETTER: 2465 case ObjectLiteral::Property::GETTER:
2465 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2466 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3);
2466 break; 2467 break;
2467 2468
2468 case ObjectLiteral::Property::SETTER: 2469 case ObjectLiteral::Property::SETTER:
2469 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2470 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3);
2470 break; 2471 break;
2471
2472 default:
2473 UNREACHABLE();
2474 } 2472 }
2475 } 2473 }
2476 2474
2477 // prototype 2475 // prototype
2478 __ CallRuntime(Runtime::kToFastProperties, 1); 2476 __ CallRuntime(Runtime::kToFastProperties, 1);
2479 2477
2480 // constructor 2478 // constructor
2481 __ CallRuntime(Runtime::kToFastProperties, 1); 2479 __ CallRuntime(Runtime::kToFastProperties, 1);
2482 } 2480 }
2483 2481
(...skipping 2738 matching lines...) Expand 10 before | Expand all | Expand 10 after
5222 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5220 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5223 Assembler::target_address_at(call_target_address, 5221 Assembler::target_address_at(call_target_address,
5224 unoptimized_code)); 5222 unoptimized_code));
5225 return OSR_AFTER_STACK_CHECK; 5223 return OSR_AFTER_STACK_CHECK;
5226 } 5224 }
5227 5225
5228 5226
5229 } } // namespace v8::internal 5227 } } // namespace v8::internal
5230 5228
5231 #endif // V8_TARGET_ARCH_X87 5229 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698