Eliminate components_unittests' dependence on chrome resources.

Eliminate components_unittests' dependence on chrome resources.

This CL changes components_unittests to create its own pakfile rather than
relying on the chrome pakfile. To do this it adds a repack step that repacks
the pakfiles that components_unittests needs into a
components_unittests_resources.pak file, and then loads that pakfile
explicitly.

This change means that components_unittests now passes after a clean build,
whereas before it would fail due to missing resources.

This is based on blundell's change: https://codereview.chromium.org/258043003/

BUG=348563, 450464
R=blundell@chromium.org, thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/045c9bf1d36f35643a077891dedf24054f2032a3

Committed: https://chromium.googlesource.com/chromium/src/+/e98e8e7654b7e51f98e92514897f8e1284eaa571

[jam, 2015-01-21 00:21:45]

Patchset #5 (id:80001) has been deleted

[jam, 2015-01-21 03:14:09]

jam@chromium.org changed reviewers:
+ blundell@chromium.org

[jam, 2015-01-21 03:15:05]

Colin: this is based on your cl, and it looks like it passes now.

[jam, 2015-01-21 03:15:53]

Patchset #7 (id:140001) has been deleted

[Nico, 2015-01-21 05:57:56]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-01-21 05:57:57]

lgtm!

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
File components/components_unittests.isolate (right):

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:6: ['OS=="android" or OS=="linux" or
OS=="mac" or OS=="win"', {
Is this false anywhere? ios?

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:27: }],
remove this block

[jam, 2015-01-21 06:00:06]

thanks for the quick review

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
File components/components_unittests.isolate (right):

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:6: ['OS=="android" or OS=="linux" or
OS=="mac" or OS=="win"', {
On 2015/01/21 05:57:57, Nico wrote:
> Is this false anywhere? ios?

the pak file isn't copied on ios. i'm not sure if isolate files are used on ios
now (i don't think they are). but i left as is to make this change smaller

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:27: }],
On 2015/01/21 05:57:57, Nico wrote:
> remove this block

yeah this was bugging me too, although at this point with green runs i will land
as is and then remove it in a followup so the tree can green

[commit-bot: I haz the power, 2015-01-21 06:06:00]

Patchset 7 (id:??) landed as
https://crrev.com/045c9bf1d36f35643a077891dedf24054f2032a3
Cr-Commit-Position: refs/heads/master@{#312306}

[jam, 2015-01-21 06:06:10]

Committed patchset #7 (id:160001) manually as
045c9bf1d36f35643a077891dedf24054f2032a3 (tree was closed).

[blundell, 2015-01-21 09:31:43]

lgtm

[sergeyv, 2015-01-21 13:09:17]

A revert of this CL (patchset #7 id:160001) has been created in
https://codereview.chromium.org/858203002/ by sergeyv@chromium.org.

The reason for reverting is: Speculative revert:

http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chro....

[M-A Ruel, 2015-01-21 13:55:45]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-01-21 13:55:45]

BTW, the reason it showed up on official build is because of the "archive after
compile" vs "check during compile".

We converted all try bots to archive after compile, so that all missing
transitive dependencies are missing. This is not the case on compile-only bots.
On the other hand, these are real bugs in the target configuration.

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
File components/components_unittests.isolate (right):

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:58: '<(PRODUCT_DIR)/<(mac_product_name)
Framework.framework/',
Error was that on official build, components_unittests_run still tried to depend
on Google Chrome Framework.framework here. I thought this was fixed by this CL.
Fix is likely to remove this line.

Link:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

--- CUT HERE ---

FAILED: cd ../../components; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=components_unittests_run;
export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/../../components;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python ../tools/isolate_driver.py check --isolated
"../out/Release/components_unittests.isolated" --isolate
"components_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Release " --extra-variable "version_full=42.0.2283.0"
--config-variable "OS=mac" --config-variable "CONFIGURATION_NAME=Release"
--config-variable "asan=0" --config-variable "chromeos=0" --config-variable
"component=static_library" --config-variable "fastbuild=0" --config-variable
"internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1"
--config-variable "v8_use_external_startup_data=1" --config-variable "lsan=0"
--config-variable "libpeer_target_type=static_library" --config-variable
"use_openssl=1" --config-variable "target_arch=x64" --config-variable
"use_ozone=0" --config-variable "disable_nacl=0" --extra-variable
mac_product_name "Google Chrome"
Traceback (most recent call last):
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 1212, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 1205, in main
    return dispatcher.execute(parser, argv)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py",
line 242, in execute
    return command(parser, args[1:])
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 945, in CMDcheck
    options, os.getcwd(), options.subdir, False)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 676, in load_complete_state
    options.extra_variables, options.blacklist, options.ignore_broken_items)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 560, in load_isolate
    ignore_broken_items)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolated_format.py",
line 300, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolated_format.py",
line 275, in expand_directory_and_symlink
    'Unable to iterate over directory %s.\n%s' % (infile, e))
isolated_format.MappingError: Unable to iterate over directory
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Google
Chrome Framework.framework/.
Input file
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Google
Chrome Framework.framework/Frameworks doesn't exist
ninja: build stopped: subcommand failed.

--- CUT HERE ---

[jam, 2015-01-21 15:12:15]

doh, I watched the tree and saw saw one green build so I thought it was fixed :)
looks like i didn't remove all the references.

I'll reland this now (without try runs, since this issue won't show up on
trybots). note that the tree is still broken, and this revert didn't really fix
it since the dependency is still in the isolate files

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
File components/components_unittests.isolate (right):

https://codereview.chromium.org/856163002/diff/160001/components/components_u...
components/components_unittests.isolate:58: '<(PRODUCT_DIR)/<(mac_product_name)
Framework.framework/',
ah, I missed this line. will remove in the reland.

[commit-bot: I haz the power, 2015-01-21 15:27:14]

Patchset 8 (id:??) landed as
https://crrev.com/e98e8e7654b7e51f98e92514897f8e1284eaa571
Cr-Commit-Position: refs/heads/master@{#312390}

[jam, 2015-01-21 15:27:27]

Committed patchset #8 (id:180001) manually as
e98e8e7654b7e51f98e92514897f8e1284eaa571 (tree was closed).

[chrishtr, 2015-01-21 23:08:27]

A revert of this CL (patchset #8 id:180001) has been created in
https://codereview.chromium.org/867473002/ by chrishtr@chromium.org.

The reason for reverting is: Causes Mac ASAN bot to fail on
BookmarkModelTest.Sort. The failures look the same as those referenced in
crbug.com/450464.

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests....