Eliminate components_unittests' dependence on chrome resources.

components/components_unittests.isolate

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'conditions': [
     ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {

[Nico, 2015/01/21 05:57:57]

Is this false anywhere? ios?

[jam, 2015/01/21 06:00:05]

the pak file isn't copied on ios. i'm not sure if isolate files are used on ios
now (i don't think they are). but i left as is to make this change smaller

       'variables': {
         'files': [
           'test/data/',
-          '<(PRODUCT_DIR)/resources.pak',
+          '<(PRODUCT_DIR)/components_unittests_resources.pak',
         ],
       },
     }],
     ['OS=="linux" or OS=="mac" or OS=="win"', {
       'variables': {
         'files': [
           '../testing/test_env.py',
           '<(PRODUCT_DIR)/components_unittests<(EXECUTABLE_SUFFIX)',
         ],
       },
     }],
     ['OS=="android" or OS=="linux" or OS=="win"', {
       'variables': {
         'files': [
-          '<(PRODUCT_DIR)/chrome_100_percent.pak',
-          '<(PRODUCT_DIR)/locales/en-US.pak',
         ],
       },
     }],

[Nico, 2015/01/21 05:57:57]

remove this block

[jam, 2015/01/21 06:00:05]

yeah this was bugging me too, although at this point with green runs i will land
as is and then remove it in a followup so the tree can green

     ['OS=="linux"', {
       'variables': {
         'command': [
           '../testing/xvfb.py',
           '<(PRODUCT_DIR)',
           '<(PRODUCT_DIR)/components_unittests',
           '--brave-new-test-launcher',
           '--test-launcher-bot-mode',
           '--asan=<(asan)',
           '--lsan=<(lsan)',
@@ skipping 10 matching lines @@
       'variables': {
         'command': [
           '../testing/test_env.py',
           '<(PRODUCT_DIR)/components_unittests',
           '--brave-new-test-launcher',
           '--test-launcher-bot-mode',
           '--asan=<(asan)',
           '--lsan=<(lsan)',
         ],
         'files': [
           '<(PRODUCT_DIR)/<(mac_product_name) Framework.framework/',

[M-A Ruel, 2015/01/21 13:55:45]

Error was that on official build, components_unittests_run still tried to depend
on Google Chrome Framework.framework here. I thought this was fixed by this CL.
Fix is likely to remove this line.

Link:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...

--- CUT HERE ---

FAILED: cd ../../components; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=components_unittests_run;
export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/../../components;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python ../tools/isolate_driver.py check --isolated
"../out/Release/components_unittests.isolated" --isolate
"components_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Release " --extra-variable "version_full=42.0.2283.0"
--config-variable "OS=mac" --config-variable "CONFIGURATION_NAME=Release"
--config-variable "asan=0" --config-variable "chromeos=0" --config-variable
"component=static_library" --config-variable "fastbuild=0" --config-variable
"internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1"
--config-variable "v8_use_external_startup_data=1" --config-variable "lsan=0"
--config-variable "libpeer_target_type=static_library" --config-variable
"use_openssl=1" --config-variable "target_arch=x64" --config-variable
"use_ozone=0" --config-variable "disable_nacl=0" --extra-variable
mac_product_name "Google Chrome"
Traceback (most recent call last):
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 1212, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 1205, in main
    return dispatcher.execute(parser, argv)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py",
line 242, in execute
    return command(parser, args[1:])
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 945, in CMDcheck
    options, os.getcwd(), options.subdir, False)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 676, in load_complete_state
    options.extra_variables, options.blacklist, options.ignore_broken_items)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolate.py",
line 560, in load_isolate
    ignore_broken_items)
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolated_format.py",
line 300, in expand_directories_and_symlinks
    indir, relfile, blacklist, follow_symlinks))
  File
"/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/swarming_client/isolated_format.py",
line 275, in expand_directory_and_symlink
    'Unable to iterate over directory %s.\n%s' % (infile, e))
isolated_format.MappingError: Unable to iterate over directory
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Google
Chrome Framework.framework/.
Input file
/Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Google
Chrome Framework.framework/Frameworks doesn't exist
ninja: build stopped: subcommand failed.

--- CUT HERE ---

[jam, 2015/01/21 15:12:15]

ah, I missed this line. will remove in the reland.

           '<(PRODUCT_DIR)/ffmpegsumo.so',
           '<(PRODUCT_DIR)/osmesa.so',
         ],
       },
     }],
     ['OS=="win"', {
       'variables': {
         'command': [
           '../testing/test_env.py',
           '<(PRODUCT_DIR)/components_unittests.exe',
@@ skipping 14 matching lines @@
         'files': [
           '<(PRODUCT_DIR)/components_unittests.exe.pdb',
         ],
       },
     }],
   ],
   'includes': [
     '../base/base.isolate',
   ],
 }