Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 855953007: Adding "static_assert" in lieu of "COMPILE_ASSERT" in gin module (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding "static_assert" in lieu of "COMPILE_ASSERT" in gin module All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/c1b6156b0820a71a933ffd5e9c28da396003dc2d Cr-Commit-Position: refs/heads/master@{#312281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gin/array_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-20 12:39:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 19:19:33 UTC) #3
anujsharma
On 2015/01/20 19:19:33, jochen (slow) wrote: > lgtm Thanks jochen for lgtm.
5 years, 11 months ago (2015-01-20 19:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855953007/1
5 years, 11 months ago (2015-01-20 19:31:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 21:48:40 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:50:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1b6156b0820a71a933ffd5e9c28da396003dc2d
Cr-Commit-Position: refs/heads/master@{#312281}

Powered by Google App Engine
This is Rietveld 408576698