gin/array_buffer.cc - Issue 855953007: Adding "static_assert" in lieu of "COMPILE_ASSERT" in gin module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/array_buffer.cc

Issue 855953007: Adding "static_assert" in lieu of "COMPILE_ASSERT" in gin module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/array_buffer.cc

diff --git a/gin/array_buffer.cc b/gin/array_buffer.cc

index b777402e644ff49a39365f623d8d79b4efb13515..d592b276eaf5497792a33c882388dd5bbddc018c 100644

--- a/gin/array_buffer.cc

+++ b/gin/array_buffer.cc

@@ -16,8 +16,8 @@ gin::WrapperInfo g_array_buffer_wrapper_info = {gin::kEmbedderNativeGin};

} // namespace

-COMPILE_ASSERT(V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT == 2,

- array_buffers_must_have_two_internal_fields);

+static_assert(V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT == 2,

+ "array buffers must have two internal fields");

// ArrayBufferAllocator -------------------------------------------------------

« no previous file with comments | « no previous file | no next file » | no next file with comments »