Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 855843002: [cc] replacing left out COMPILE_ASSERT with static_assert (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in cc/ All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/fdaa7e3d779e5faa947b4c0b8e2391a976ea8390 Cr-Commit-Position: refs/heads/master@{#312277}

Patch Set 1 #

Patch Set 2 : Checking alignments #

Total comments: 2

Patch Set 3 : Fixing nits #

Total comments: 2

Patch Set 4 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/resources/tile_manager.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-19 13:21:58 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/855843002/diff/20001/cc/resources/tile_manager.h File cc/resources/tile_manager.h (right): https://codereview.chromium.org/855843002/diff/20001/cc/resources/tile_manager.h#newcode103 cc/resources/tile_manager.h:103: "NamedTaskSet ALL should be equal or greater then that ...
5 years, 11 months ago (2015-01-19 17:20:46 UTC) #4
anujsharma
Thanks mostyn for review. I have fixed your comment. PTAL https://codereview.chromium.org/855843002/diff/20001/cc/resources/tile_manager.h File cc/resources/tile_manager.h (right): https://codereview.chromium.org/855843002/diff/20001/cc/resources/tile_manager.h#newcode103 ...
5 years, 11 months ago (2015-01-20 03:11:01 UTC) #5
Mostyn Bramley-Moore
https://codereview.chromium.org/855843002/diff/40001/cc/resources/tile_manager.h File cc/resources/tile_manager.h (right): https://codereview.chromium.org/855843002/diff/40001/cc/resources/tile_manager.h#newcode103 cc/resources/tile_manager.h:103: "NamedTaskSet::ALL should not be equal to kNumberOfTaskSets" This should ...
5 years, 11 months ago (2015-01-20 09:54:57 UTC) #6
anujsharma
Oops missed it..sry https://codereview.chromium.org/855843002/diff/40001/cc/resources/tile_manager.h File cc/resources/tile_manager.h (right): https://codereview.chromium.org/855843002/diff/40001/cc/resources/tile_manager.h#newcode103 cc/resources/tile_manager.h:103: "NamedTaskSet::ALL should not be equal to ...
5 years, 11 months ago (2015-01-20 09:56:25 UTC) #7
anujsharma
@Mostyn PTAL
5 years, 11 months ago (2015-01-20 10:02:18 UTC) #8
Mostyn Bramley-Moore
non-OWNER lgtm. You might want to try a different reviewer, piman looks busy.
5 years, 11 months ago (2015-01-20 10:09:20 UTC) #9
anujsharma
@piman Could you please have a look on this CL. Thanks!!
5 years, 11 months ago (2015-01-20 13:53:47 UTC) #10
piman
lgtm
5 years, 11 months ago (2015-01-20 19:23:30 UTC) #11
anujsharma
On 2015/01/20 19:23:30, piman (Very slow to review) wrote: > lgtm Thanks piman for lgtm.
5 years, 11 months ago (2015-01-20 19:28:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855843002/60001
5 years, 11 months ago (2015-01-20 19:29:39 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-20 21:36:22 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:37:09 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fdaa7e3d779e5faa947b4c0b8e2391a976ea8390
Cr-Commit-Position: refs/heads/master@{#312277}

Powered by Google App Engine
This is Rietveld 408576698