Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: cc/resources/tile_manager.h

Issue 855843002: [cc] replacing left out COMPILE_ASSERT with static_assert (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing nits Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_RESOURCES_TILE_MANAGER_H_ 5 #ifndef CC_RESOURCES_TILE_MANAGER_H_
6 #define CC_RESOURCES_TILE_MANAGER_H_ 6 #define CC_RESOURCES_TILE_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <set> 10 #include <set>
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 public: 92 public:
93 enum NamedTaskSet { 93 enum NamedTaskSet {
94 REQUIRED_FOR_ACTIVATION, 94 REQUIRED_FOR_ACTIVATION,
95 REQUIRED_FOR_DRAW, 95 REQUIRED_FOR_DRAW,
96 // PixelBufferTileTaskWorkerPool depends on ALL being last. 96 // PixelBufferTileTaskWorkerPool depends on ALL being last.
97 ALL 97 ALL
98 // Adding additional values requires increasing kNumberOfTaskSets in 98 // Adding additional values requires increasing kNumberOfTaskSets in
99 // rasterizer.h 99 // rasterizer.h
100 }; 100 };
101 101
102 COMPILE_ASSERT(NamedTaskSet::ALL == (kNumberOfTaskSets - 1), 102 static_assert(NamedTaskSet::ALL == (kNumberOfTaskSets - 1),
103 NamedTaskSet_ALL_not_kNumberOfTaskSets_minus_1); 103 "NamedTaskSet::ALL should not be equal to kNumberOfTaskSets"
Mostyn Bramley-Moore 2015/01/20 09:54:57 This should read "should be equal to".
anujsharma 2015/01/20 09:56:24 oops sry..missed it.
104 "minus 1");
104 105
105 static scoped_ptr<TileManager> Create(TileManagerClient* client, 106 static scoped_ptr<TileManager> Create(TileManagerClient* client,
106 base::SequencedTaskRunner* task_runner, 107 base::SequencedTaskRunner* task_runner,
107 ResourcePool* resource_pool, 108 ResourcePool* resource_pool,
108 TileTaskRunner* tile_task_runner, 109 TileTaskRunner* tile_task_runner,
109 Rasterizer* rasterizer, 110 Rasterizer* rasterizer,
110 size_t scheduled_raster_task_limit); 111 size_t scheduled_raster_task_limit);
111 ~TileManager() override; 112 ~TileManager() override;
112 113
113 // Assigns tile memory and schedules work to prepare tiles for drawing. 114 // Assigns tile memory and schedules work to prepare tiles for drawing.
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 310
310 bool did_notify_ready_to_activate_; 311 bool did_notify_ready_to_activate_;
311 bool did_notify_ready_to_draw_; 312 bool did_notify_ready_to_draw_;
312 313
313 DISALLOW_COPY_AND_ASSIGN(TileManager); 314 DISALLOW_COPY_AND_ASSIGN(TileManager);
314 }; 315 };
315 316
316 } // namespace cc 317 } // namespace cc
317 318
318 #endif // CC_RESOURCES_TILE_MANAGER_H_ 319 #endif // CC_RESOURCES_TILE_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698