Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/renderer/resources/extensions/notifications_custom_bindings.js

Issue 855813002: Mark create/update/clear callbacks of notification API as optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark ID as optional, add test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/notifications_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/notifications_custom_bindings.js b/chrome/renderer/resources/extensions/notifications_custom_bindings.js
index eebf2900920287f0b539b04e32d48e6219a2c444..fc6b442576bcc335061638e13b54d5c3693b89f3 100644
--- a/chrome/renderer/resources/extensions/notifications_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/notifications_custom_bindings.js
@@ -7,6 +7,7 @@
var binding = require('binding').Binding.create('notifications');
var sendRequest = require('sendRequest').sendRequest;
+var exceptionHandler = require('uncaught_exception_handler');
var imageUtil = require('imageUtil');
var lastError = require('lastError');
var notificationsPrivate = requireNative('notifications_private');
@@ -111,20 +112,21 @@ function genHandle(name, failure_function) {
return function(id, input_notification_details, callback) {
// TODO(dewittj): Remove this hack. This is used as a way to deep
// copy a complex JSON object.
- var notification_details = JSON.parse(
- JSON.stringify(input_notification_details));
+ var notification_details = $JSON.parse(
+ $JSON.stringify(input_notification_details));
var that = this;
+ var stack = exceptionHandler.getExtensionStackTrace();
replaceNotificationOptionURLs(notification_details, function(success) {
if (success) {
sendRequest(that.name,
[id, notification_details, callback],
- that.definition.parameters);
+ that.definition.parameters, {stack: stack});
return;
}
lastError.run(name,
'Unable to download all specified images.',
- null,
- failure_function, [callback, id])
+ stack,
+ failure_function, [callback || function() {}, id]);
});
};
}

Powered by Google App Engine
This is Rietveld 408576698