Chromium Code Reviews| Index: chrome/common/extensions/api/notifications.idl |
| diff --git a/chrome/common/extensions/api/notifications.idl b/chrome/common/extensions/api/notifications.idl |
| index fb1fe65b98977bd6430b043c8f92f0af55287492..31bb6e5a9d9727062e80ed4741633d2febb98e3d 100644 |
| --- a/chrome/common/extensions/api/notifications.idl |
| +++ b/chrome/common/extensions/api/notifications.idl |
| @@ -124,31 +124,36 @@ namespace notifications { |
| interface Functions { |
| // Creates and displays a notification. |
| - // |notificationId|: Identifier of the notification. If it is empty, this |
| - // method generates an id. If it matches an existing notification, this |
| - // method first clears that notification before proceeding with the create |
| - // operation. |
| + // |notificationId|: Identifier of the notification. If not set or empty, an |
| + // ID will automatically be generated. If it matches an existing |
| + // notification, this method first clears that notification before |
| + // proceeding with the create operation. |
| + // The parameter was required before Chrome 42. |
|
not at google - send to devlin
2015/02/03 18:08:20
s/was/is/g
same below.
could you also put it on
robwu
2015/02/03 18:13:08
Done.
|
| // |options|: Contents of the notification. |
| // |callback|: Returns the notification id (either supplied or generated) |
| // that represents the created notification. |
| - static void create(DOMString notificationId, |
| + // The callback was required before Chrome 42. |
| + static void create(optional DOMString notificationId, |
| NotificationOptions options, |
| - CreateCallback callback); |
| + optional CreateCallback callback); |
| // Updates an existing notification. |
| // |notificationId|: The id of the notification to be updated. This is |
| // returned by $(ref:notifications.create) method. |
| // |options|: Contents of the notification to update to. |
| // |callback|: Called to indicate whether a matching notification existed. |
| + // The callback was required before Chrome 42. |
| static void update(DOMString notificationId, |
| NotificationOptions options, |
| - UpdateCallback callback); |
| + optional UpdateCallback callback); |
| // Clears the specified notification. |
| // |notificationId|: The id of the notification to be cleared. This is |
| // returned by $(ref:notifications.create) method. |
| // |callback|: Called to indicate whether a matching notification existed. |
| - static void clear(DOMString notificationId, ClearCallback callback); |
| + // The callback was required before Chrome 42. |
| + static void clear(DOMString notificationId, |
| + optional ClearCallback callback); |
| // Retrieves all the notifications. |
| // |callback|: Returns the set of notification_ids currently in the system. |