Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Issue 855763004: Enable find-missing-symbols-at-link-time for official builds too. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable find-missing-symbols-at-link-time for official builds too. BUG=371125 Committed: https://crrev.com/b43e6cc69ecb0049bbcd84b41cd13847cd01bc4b Cr-Commit-Position: refs/heads/master@{#312345}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
From what I can tell, this Just Works.
5 years, 11 months ago (2015-01-21 00:53:26 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-21 00:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855763004/1
5 years, 11 months ago (2015-01-21 03:29:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25141)
5 years, 11 months ago (2015-01-21 03:34:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855763004/20001
5 years, 11 months ago (2015-01-21 03:39:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:11:50 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:13:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b43e6cc69ecb0049bbcd84b41cd13847cd01bc4b
Cr-Commit-Position: refs/heads/master@{#312345}

Powered by Google App Engine
This is Rietveld 408576698