Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 855583002: Revert of Revert of cc: Remove tile rasterize on demand for GPU rasterization (Closed)

Created:
5 years, 11 months ago by hendrikw
Modified:
5 years, 11 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #1 id:1 of https://codereview.chromium.org/832353004/) Reason for revert: this will conflict with vmpstr's change :( Original issue's description: > Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #2 id:20001 of https://codereview.chromium.org/842483003/) > > Reason for revert: > Speculative revert for https://code.google.com/p/chromium/issues/detail?id=449288 > > Original issue's description: > > cc: Remove tile rasterize on demand for GPU rasterization > > > > This code was recently added and isn't needed because it signals to the tile > > that it should raster on demand (checkerboard), but this will happen anyway with > > the delgated renderer. > > > > I've also removed a test that was breaking due to the change. > > > > The test wasn't really testing what we thought, because we wouldn't end up > > rasterizing anything with GPU, even though force was on. > > > > Committed: https://crrev.com/01a4b8027c2e9e678cd6afd0a97bf83807d55f5a > > Cr-Commit-Position: refs/heads/master@{#311109} > > TBR=vmpstr@chromium.org,danakj@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/6bf7f22dd46c31ffcf72e48397edf3ec08533ad5 > Cr-Commit-Position: refs/heads/master@{#311764} TBR=vmpstr@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6020325265321d81c9ea4e34fdf6ed718ba300ef Cr-Commit-Position: refs/heads/master@{#311769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M cc/resources/tile_manager.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hendrikw
Created Revert of Revert of cc: Remove tile rasterize on demand for GPU rasterization
5 years, 11 months ago (2015-01-15 23:33:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/855583002/1
5 years, 11 months ago (2015-01-15 23:36:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:38:07 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:39:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6020325265321d81c9ea4e34fdf6ed718ba300ef
Cr-Commit-Position: refs/heads/master@{#311769}

Powered by Google App Engine
This is Rietveld 408576698