Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h - Issue 855413002: [New Multicolumn] Support for block direction margins on spanners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

Issue 855413002: [New Multicolumn] Support for block direction margins on spanners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/span/adjacent-spanners-with-margin.html ('K') | « Source/core/rendering/RenderMultiColumnSet.h ('k') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

diff --git a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

index 28173449687145e4c6cd709d7d4eaec633d5dfa6..28770c6b758403c88e54285f84509a6f8fe15ee0 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

+++ b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

@@ -24,6 +24,7 @@ public:

RenderBox* rendererInFlowThread() const { return m_rendererInFlowThread; }

void setRendererInFlowThread(RenderBox* renderer) { m_rendererInFlowThread = renderer; }

void spannerWillBeRemoved();

+ void updateMarginProperties();

protected:

virtual void willBeRemovedFromTree() override;