Source/core/rendering/RenderMultiColumnSet.h - Issue 855413002: [New Multicolumn] Support for block direction margins on spanners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSet.h

Issue 855413002: [New Multicolumn] Support for block direction margins on spanners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/span/adjacent-spanners-with-margin.html ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSet.h

diff --git a/Source/core/rendering/RenderMultiColumnSet.h b/Source/core/rendering/RenderMultiColumnSet.h

index 5a75a77fe1964fd72531e871fa797fb5feb1f540..263055e34947fc87a7c3125c1b29bcdbd928f925 100644

--- a/Source/core/rendering/RenderMultiColumnSet.h

+++ b/Source/core/rendering/RenderMultiColumnSet.h

@@ -146,6 +146,8 @@ private:

virtual void insertedIntoTree() override final;

virtual void willBeRemovedFromTree() override final;

+ virtual bool isSelfCollapsingBlock() const override { return false; }

virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;

virtual void paintObject(const PaintInfo&, const LayoutPoint& paintOffset) override;