Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 855013002: Make mem{cpy,move,set} pnacl bitcode disablement apply to biased bitcode. (Closed)

Created:
5 years, 11 months ago by jvoung (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
Derek Schuff, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-newlib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make mem{cpy,move,set} pnacl bitcode disablement apply to biased bitcode. This is to avoid miscompilations where the bitcode functions are specialized to an incomplete set of the callers (more callers introduced very late by codegen). Previously this only applied to __pnacl__ and not biased bitcode. Use a separate preprocessor define to disable. Must update DEPS along with: https://codereview.chromium.org/844473003/ Fixes the callingconv test failure in: BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026 R=dschuff@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=da717459e4577690dfce366a17202df8d01281ce

Patch Set 1 #

Patch Set 2 : add comment #

Total comments: 4

Patch Set 3 : comment everywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M newlib/libc/string/memcpy.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M newlib/libc/string/memmove.c View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M newlib/libc/string/memset.c View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 11 months ago (2015-01-16 17:20:58 UTC) #2
Derek Schuff
otherwise lgtm https://codereview.chromium.org/855013002/diff/20001/newlib/libc/string/memmove.c File newlib/libc/string/memmove.c (right): https://codereview.chromium.org/855013002/diff/20001/newlib/libc/string/memmove.c#newcode39 newlib/libc/string/memmove.c:39: * The body of this function should ...
5 years, 11 months ago (2015-01-16 17:29:06 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/855013002/diff/20001/newlib/libc/string/memmove.c File newlib/libc/string/memmove.c (right): https://codereview.chromium.org/855013002/diff/20001/newlib/libc/string/memmove.c#newcode39 newlib/libc/string/memmove.c:39: * The body of this function should not appear ...
5 years, 11 months ago (2015-01-16 17:54:44 UTC) #4
jvoung (off chromium)
5 years, 11 months ago (2015-01-16 19:09:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
da717459e4577690dfce366a17202df8d01281ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698