Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 8549011: Content settings UI for mouse lock (Closed)

Created:
9 years, 1 month ago by scheib
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews), tony, koz (OOO until 15th September), yzshen
Visibility:
Public.

Description

Content settings UI for mouse lock BUG=97768 TEST=Preferences / Under the hood / Content Settings / Mouse Lock should exist and function similar to Location Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111395

Patch Set 1 #

Patch Set 2 : rebase TOT #

Patch Set 3 : Strings from Brian used #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +15 lines, -0 lines 2 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
scheib
Glen - I'll need some UI Strings to use in the Content Settings for Mouse ...
9 years, 1 month ago (2011-11-18 02:33:04 UTC) #1
scheib
Evan, can you review this (or suggest another)?
9 years, 1 month ago (2011-11-18 18:56:56 UTC) #2
scheib
Jochen, added you as I haven't gotten a response from Evan yet Either, can you ...
9 years, 1 month ago (2011-11-22 20:12:40 UTC) #3
scheib
markusheintz, jochen recommended you as a reviewer for this - can you take it or ...
9 years, 1 month ago (2011-11-22 20:17:35 UTC) #4
markusheintz_
LGTM. But please also add a reviewer for the WebUI parts. Maybe koz@, kevers@ or ...
9 years, 1 month ago (2011-11-22 21:32:46 UTC) #5
scheib
koz, can you review webui?
9 years, 1 month ago (2011-11-22 21:34:48 UTC) #6
koz (OOO until 15th September)
lgtm
9 years, 1 month ago (2011-11-22 22:37:30 UTC) #7
Evan Stade
lgtm
9 years, 1 month ago (2011-11-22 22:55:20 UTC) #8
Evan Stade
http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd#newcode6149 chrome/app/generated_resources.grd:6149: Allow all sites to hide the mouse cursor it's ...
9 years, 1 month ago (2011-11-22 22:59:43 UTC) #9
scheib
http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd#newcode6149 chrome/app/generated_resources.grd:6149: Allow all sites to hide the mouse cursor On ...
9 years, 1 month ago (2011-11-22 23:28:35 UTC) #10
scheib
Discussion with Brian resulted in staying with strings as currently entered in this change. On ...
9 years, 1 month ago (2011-11-23 18:37:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/8549011/7001
9 years, 1 month ago (2011-11-23 18:38:13 UTC) #12
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 19:51:36 UTC) #13
Change committed as 111395

Powered by Google App Engine
This is Rietveld 408576698