Chromium Code Reviews
Help | Chromium Project | Sign in
(1117)

Issue 8549011: Content settings UI for mouse lock (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by scheib
Modified:
2 years, 4 months ago
CC:
chromium-reviews_chromium.org, arv, tony, koz, yzshen
Visibility:
Public.

Description

Content settings UI for mouse lock

BUG=97768
TEST=Preferences / Under the hood / Content Settings / Mouse Lock should exist and function similar to Location


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111395

Patch Set 1 #

Patch Set 2 : rebase TOT #

Patch Set 3 : Strings from Brian used #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +15 lines, -0 lines 2 comments ? errors Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/content_settings.html View 1 1 chunk +26 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 1 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 chunks +6 lines, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 13
scheib
Glen - I'll need some UI Strings to use in the Content Settings for Mouse ...
2 years, 5 months ago #1
scheib
Evan, can you review this (or suggest another)?
2 years, 5 months ago #2
scheib
Jochen, added you as I haven't gotten a response from Evan yet Either, can you ...
2 years, 4 months ago #3
scheib
markusheintz, jochen recommended you as a reviewer for this - can you take it or ...
2 years, 4 months ago #4
markusheintz_
LGTM. But please also add a reviewer for the WebUI parts. Maybe koz@, kevers@ or ...
2 years, 4 months ago #5
scheib
koz, can you review webui?
2 years, 4 months ago #6
koz
lgtm
2 years, 4 months ago #7
Evan Stade
lgtm
2 years, 4 months ago #8
Evan Stade
http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd#newcode6149 chrome/app/generated_resources.grd:6149: Allow all sites to hide the mouse cursor it's ...
2 years, 4 months ago #9
scheib
http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/8549011/diff/7001/chrome/app/generated_resources.grd#newcode6149 chrome/app/generated_resources.grd:6149: Allow all sites to hide the mouse cursor On ...
2 years, 4 months ago #10
scheib
Discussion with Brian resulted in staying with strings as currently entered in this change. On ...
2 years, 4 months ago #11
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/8549011/7001
2 years, 4 months ago #12
I haz the power (commit-bot)
2 years, 4 months ago #13
Change committed as 111395
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6