Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 854733002: [Android] Fixes for instrumentation in platform mode. (Closed)

Created:
5 years, 11 months ago by jbudorick
Modified:
5 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, jayker_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fixes for instrumentation in platform mode. https://codereview.chromium.org/794923003/ had a few problems: - it broke uiautomator test output parsing - it had a typo in InstrumentationTestInstance - it had an error in how it handles instrumentation's test dict objects BUG=428729 Committed: https://crrev.com/a4dac37b42fa1aa2e02073e00dc55e70159268d0 Cr-Commit-Position: refs/heads/master@{#311575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 2 chunks +5 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 11 months ago (2015-01-14 20:37:13 UTC) #2
klundberg
LGTM after John in person explained how the various method is overwritten in various places.
5 years, 11 months ago (2015-01-14 21:39:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854733002/1
5 years, 11 months ago (2015-01-14 21:41:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 23:53:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:54:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4dac37b42fa1aa2e02073e00dc55e70159268d0
Cr-Commit-Position: refs/heads/master@{#311575}

Powered by Google App Engine
This is Rietveld 408576698