Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: build/android/pylib/local/device/local_device_test_run.py

Issue 854733002: [Android] Fixes for instrumentation in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 6
7 from pylib import valgrind_tools 7 from pylib import valgrind_tools
8 from pylib.base import base_test_result 8 from pylib.base import base_test_result
9 from pylib.base import test_run 9 from pylib.base import test_run
10 from pylib.base import test_collection 10 from pylib.base import test_collection
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 run_tests_on_device, tests).pGet(None) 51 run_tests_on_device, tests).pGet(None)
52 for try_result in try_results: 52 for try_result in try_results:
53 for result in try_result.GetAll(): 53 for result in try_result.GetAll():
54 if result.GetType() in (base_test_result.ResultType.PASS, 54 if result.GetType() in (base_test_result.ResultType.PASS,
55 base_test_result.ResultType.SKIP): 55 base_test_result.ResultType.SKIP):
56 results.AddResult(result) 56 results.AddResult(result)
57 else: 57 else:
58 all_fail_results[result.GetName()] = result 58 all_fail_results[result.GetName()] = result
59 59
60 results_names = set(r.GetName() for r in results.GetAll()) 60 results_names = set(r.GetName() for r in results.GetAll())
61 tests = [t for t in tests if t not in results_names] 61 tests = [t for t in tests if self._GetTestName(t) not in results_names]
62 tries += 1 62 tries += 1
63 63
64 all_unknown_test_names = set(tests) 64 all_unknown_test_names = set(tests)
65 all_failed_test_names = set(all_fail_results.iterkeys()) 65 all_failed_test_names = set(all_fail_results.iterkeys())
66 66
67 unknown_tests = all_unknown_test_names.difference(all_failed_test_names) 67 unknown_tests = all_unknown_test_names.difference(all_failed_test_names)
68 failed_tests = all_failed_test_names.intersection(all_unknown_test_names) 68 failed_tests = all_failed_test_names.intersection(all_unknown_test_names)
69 69
70 if unknown_tests: 70 if unknown_tests:
71 results.AddResults( 71 results.AddResults(
72 base_test_result.BaseTestResult( 72 base_test_result.BaseTestResult(
73 t, base_test_result.ResultType.UNKNOWN) 73 t, base_test_result.ResultType.UNKNOWN)
74 for t in tests) 74 for t in tests)
75 if failed_tests: 75 if failed_tests:
76 results.AddResults(all_fail_results[f] for f in failed_tests) 76 results.AddResults(all_fail_results[f] for f in failed_tests)
77 return results 77 return results
78 78
79 def GetTool(self, device): 79 def GetTool(self, device):
80 if not str(device) in self._tools: 80 if not str(device) in self._tools:
81 self._tools[str(device)] = valgrind_tools.CreateTool( 81 self._tools[str(device)] = valgrind_tools.CreateTool(
82 self._env.tool, device) 82 self._env.tool, device)
83 return self._tools[str(device)] 83 return self._tools[str(device)]
84 84
85 def _CreateShards(self, tests): 85 def _CreateShards(self, tests):
86 raise NotImplementedError 86 raise NotImplementedError
87 87
88 def _GetTestName(self, test):
89 return test
90
88 def _GetTests(self): 91 def _GetTests(self):
89 raise NotImplementedError 92 raise NotImplementedError
90 93
91 def _RunTest(self, device, test): 94 def _RunTest(self, device, test):
92 raise NotImplementedError 95 raise NotImplementedError
93 96
94 def _ShouldShard(self): 97 def _ShouldShard(self):
95 raise NotImplementedError 98 raise NotImplementedError
OLDNEW
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698