Issue 854683002: Revert of Remove make-file-arrays.py script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 854683002: Revert of Remove make-file-arrays.py script (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo

Modified:
5 years, 11 months ago

Reviewers:
vivekg, jochen (gone - plz use gerrit), vivekg_samsung

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Remove make-file-arrays.py script (patchset #1 id:1 of https://codereview.chromium.org/571563002/) Reason for revert: Had to revert this one because https://codereview.chromium.org/573553002/ is reverted Original issue's description: > Remove make-file-arrays.py script > > Removing the script used to generate the string arrays for blink. > > BUG=312586 > > R=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188397 TBR=jochen@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188405

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+210 lines, -0 lines)			Patch
A	Source/build/make_file_arrays.gni	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	Source/build/scripts/make-file-arrays.py	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	Source/modules/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854683002/1

5 years, 11 months ago (2015-01-14 18:34:39 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 18:35:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188405