src/core/SkLineClipper.cpp - Issue 85463005: remove SkFloatToScalar macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkLineClipper.cpp

Issue 85463005: remove SkFloatToScalar macro (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: add failing test back Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkLineClipper.cpp

diff --git a/src/core/SkLineClipper.cpp b/src/core/SkLineClipper.cpp

index fc4e3d259285a0d725e64a2a9c6555f10b130776..911cd974da53325dce3c1859475e0d93a917d558 100644

--- a/src/core/SkLineClipper.cpp

+++ b/src/core/SkLineClipper.cpp

@@ -176,7 +176,7 @@ static bool is_between_unsorted(SkScalar value,

static void sect_with_horizontal_test_for_pin_results() {

const SkPoint pts[] = {

{ -540000, -720000 },

- { SkFloatToScalar(-9.10000017e-05f), SkFloatToScalar(9.99999996e-13f) }

+ { -9.10000017e-05f, 9.99999996e-13f }

};

float x = sect_with_horizontal(pts, 0);

SkASSERT(is_between_unsorted(x, pts[0].fX, pts[1].fX));