src/core/SkGeometry.cpp - Issue 85463005: remove SkFloatToScalar macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkGeometry.cpp

Issue 85463005: remove SkFloatToScalar macro (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: add failing test back Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkGeometry.cpp

diff --git a/src/core/SkGeometry.cpp b/src/core/SkGeometry.cpp

index 9b15f9f1f9429e5c5ad3455b07e78f60ea00721e..11d52b594e303495a73523090f30d33a01216679 100644

--- a/src/core/SkGeometry.cpp

+++ b/src/core/SkGeometry.cpp

@@ -1134,9 +1134,9 @@ bool SkXRayCrossesMonotonicCubic(const SkXRay& pt, const SkPoint cubic[4], bool*

// instead of down

if (cubic[3].fY > cubic[0].fY) {

upper_t = SK_Scalar1;

- lower_t = SkFloatToScalar(0);

+ lower_t = 0;

} else {

- upper_t = SkFloatToScalar(0);

+ upper_t = 0;

lower_t = SK_Scalar1;

}

do {